Meaningful error when pushing a root docker image #2836
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This is how `ExposedPorts` are described in the OCI image config spec: https://github.com/opencontainers/image-spec/blob/main/config.md Co-authored-by: Danail Branekov <danailster@gmail.com>
In contrast to buildpack packages where Korifi creates the source image, the source image for docker packages has been created by someone in advance. Therefore Korifi should not try to clean it up on CFPackage finalization. Co-authored-by: Danail Branekov <danailster@gmail.com>
Fixes #2799 Co-authored-by: Georgi Sabev <georgethebeatle@gmail.com>
georgethebeatle
approved these changes
Aug 29, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
#2799
What is this change about?
Users should see a meaningful error when pushing a docker images that is configured to run as root
Does this PR introduce a breaking change?
No
Acceptance Steps
See #2799
Tag your pair, your PM, and/or team
@georgethebeatle