fix docker controller flakes #2839
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Also, the docker config json generator can generate configs for multiple servers
Thus we eliminate flakes and lay the foundations for testing future stories
georgethebeatle
approved these changes
Aug 30, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
What is this change about?
Fixes https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/11604 and https://ci.korifi.cf-app.com/teams/main/pipelines/main/jobs/run-tests-periodic/builds/11606
Does this PR introduce a breaking change?
No
Acceptance Steps
Green tests
Tag your pair, your PM, and/or team
@danail-branekov