Configure whether to set workload pod seccompProfile #3163
Merged
+127
−49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
PR #3156 changes the definition of statefulset/job by setting the seccomp profile on the statefulset/job template spec. This causes all workload pods to get automatically restarted when upgrading from previous Korifi releases. We introduce new `statefulsetRunnerTemporarySetPodSeccompProfile` and `jobTaskRunnerTemporarySetPodSeccompProfile` helm values whose default value would prevent altering existing statefulsets and jobs. Those will be probably removed in future releases. Co-authored-by: Danail Branekov <danailster@gmail.com>
danail-branekov
force-pushed
the
issues/configure-setting-seccompProfile-on-pod
branch
from
26525c5
to
3942195
Compare
georgethebeatle
approved these changes
Mar 12, 2024
georgethebeatle
deleted the
issues/configure-setting-seccompProfile-on-pod
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Is there a related GitHub Issue?
No
What is this change about?
PR #3156 changes the
definition of statefulset/job by setting the seccomp profile on the
statefulset/job template spec. This causes all workload pods to get
automatically restarted when upgrading from previous Korifi releases.
We introduce new
statefulsetRunnerTemporarySetPodSeccompProfileandjobTaskRunnerTemporarySetPodSeccompProfilehelm values whose defaultvalue would prevent altering existing statefulsets and jobs.
Those will be probably removed in future releases.
Does this PR introduce a breaking change?
No, it fixes a breaking change
Acceptance Steps
No restart of workload pods on Korifi upgrade
Tag your pair, your PM, and/or team
@shanman190