Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add initial /v3/info endpoint #3239

Merged
merged 1 commit into from
May 7, 2024

Conversation

gogolok
Copy link
Contributor

@gogolok gogolok commented May 1, 2024

Is there a related GitHub Issue?

#2914

What is this change about?

Add initial v3/info endpoint that presents the fields as implmented in
https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/controllers/v3/info_controller.rb
and
https://github.com/cloudfoundry/cloud_controller_ng/blob/main/app/presenters/v3/info_presenter.rb
with some static default values for the time being.

This change is the first step in getting a working v3/info endpoint implementation.
The next step would be to extend Korifi via configuration to provide some dynamic content (For example the description field and others) to be returned by the endpoint v3/info.

Does this PR introduce a breaking change?

No, it adds a new endpoint not available before.

Acceptance Steps

  • Switch to the Git branch.
  • Setup local dev environment, ./scripts/deploy-on-kind.sh korifi
  • cf api https://localhost --skip-ssl-validation
  • cf login
  • Run cf curl v3/info and see the following static content (except for the base url):
{"build":"","cli_version":{"minimum":"","recommended":""},"description":"","name":"","version":0,"custom":{},"links":{"self":{"href":"https://localhost/v3/info"},"support":{"href":"https://www.cloudfoundry.org/technology/korifi/"}}}

Tag your pair, your PM, and/or team

None

@georgethebeatle
Copy link
Member

Thanks @gogolok, looking good!

@danail-branekov danail-branekov enabled auto-merge (rebase) May 7, 2024 09:28
auto-merge was automatically disabled May 7, 2024 09:28

Head branch was pushed to by a user without write access

The provided information is static and cannot be configured yet.
@danail-branekov danail-branekov enabled auto-merge (rebase) May 7, 2024 09:33
@danail-branekov danail-branekov merged commit 232f6a8 into cloudfoundry:main May 7, 2024
11 checks passed
@gogolok gogolok deleted the v3_info_endpoint branch May 7, 2024 10:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants