Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add GET /v3/apps/:guid/environment_variables endpoint #3583

Open
wants to merge 2 commits into
base: main
Choose a base branch
from

Conversation

gogolok
Copy link
Contributor

@gogolok gogolok commented Nov 1, 2024

Is there a related GitHub Issue?

Fixes #2332

What is this change about?

It adds the missing endpoint GET /v3/apps/:guid/environment_variables.

Does this PR introduce a breaking change?

No.

Acceptance Steps

On a running Korifi instance push an app, set a env variable (via cf set-env), get the app guid and then run the cf curl /v3/apps/:guid/environment_variables command. It should output something similar to:

{
   "links" : {
      "app" : {
         "href" : "https://localhost/v3/apps/a6cb4e95-65a1-475a-b905-4ce6fac4cf88"
      },
      "self" : {
         "href" : "https://localhost/v3/apps/a6cb4e95-65a1-475a-b905-4ce6fac4cf88/environment_variables"
      }
   },
   "var" : {
      "key0" : "value"
   }
}

@gogolok gogolok force-pushed the add_get_app_env_vars_endpoint branch from 471387b to 4a12b31 Compare November 1, 2024 14:46
@gogolok gogolok force-pushed the add_get_app_env_vars_endpoint branch 3 times, most recently from 2ac43f4 to 4885969 Compare November 3, 2024 01:22
@georgethebeatle georgethebeatle enabled auto-merge (squash) November 4, 2024 14:21
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

[Feature]: Korifi API users should be able to get app env vars
3 participants