Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Remove pkg/ from .gitignore #159

Merged
merged 2 commits into from
May 8, 2024
Merged

Remove pkg/ from .gitignore #159

merged 2 commits into from
May 8, 2024

Conversation

acrmp
Copy link
Member

@acrmp acrmp commented May 8, 2024

Description

  • This was causing linting failures due to subdirectories of vendored modules being ignored.
  • I think the .gitignore entry dates from when this repo set itself as the GOPATH and Go would generate files to that directory.

Type of change

  • Bug fix (non-breaking change which fixes an issue)
  • New feature (non-breaking change which adds functionality)
  • Breaking change (fix or feature that would cause existing functionality to not work as expected)
  • This change requires a documentation update

Testing performed?

  • Unit tests
  • Integration tests
  • Acceptance tests

Checklist:

  • This PR is being made against the main branch, or relevant version branch
  • I have made corresponding changes to the documentation
  • I have added testing for my changes

If you have any questions, or want to get attention for a PR or issue please reach out on the #logging-and-metrics channel in the cloudfoundry slack

- This was causing linting failures due to subdirectories of vendored
  modules being ignored.
- I think the .gitignore entry dates from when this repo set itself as
  the GOPATH and Go would generate files to that directory.
@acrmp acrmp requested a review from a team as a code owner May 8, 2024 01:25
@ctlong
Copy link
Member

ctlong commented May 8, 2024

It looks like the tests and linting are still failing?

@acrmp
Copy link
Member Author

acrmp commented May 8, 2024

I'd planned on having our tooling commit the missing files once the exclusion was removed but have now pushed a second commit with the previously excluded files.

@acrmp acrmp merged commit 781d6d6 into main May 8, 2024
5 checks passed
@acrmp acrmp deleted the fix/remove-pkg-from-gitignore branch May 8, 2024 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants