Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fixes #1636 Client creation endpoint does not accept two secrets to s… #1651

Merged
merged 1 commit into from
Sep 14, 2021
Merged

Fixes #1636 Client creation endpoint does not accept two secrets to s… #1651

merged 1 commit into from
Sep 14, 2021

Conversation

tkurylek
Copy link
Contributor

…upport rotation

@linux-foundation-easycla
Copy link

linux-foundation-easycla bot commented Aug 19, 2021 •
edited
Loading

CLA Signed

The committers are authorized under a signed CLA.

@cf-gitbot
Copy link

We have created an issue in Pivotal Tracker to manage this:

https://www.pivotaltracker.com/story/show/179279641

The labels on this github issue will be updated when the story is started.

@tkurylek tkurylek mentioned this pull request Aug 19, 2021
Closed
strehle
strehle approved these changes Aug 27, 2021
View reviewed changes
Copy link
Member

@strehle strehle left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, but someone from VMwares team should check if this approach is ok with their thoughts

@strehle strehle merged commit 6bc2818 into cloudfoundry:develop Sep 14, 2021
@tkurylek tkurylek deleted the issue/1636 branch October 8, 2021 06:06
@cf-gitbot cf-gitbot added accepted Accepted the issue and removed unscheduled labels Jun 21, 2023
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@strehle strehle strehle approved these changes

@bruce-ricard bruce-ricard Awaiting requested review from bruce-ricard

@peterhaochen47 peterhaochen47 Awaiting requested review from peterhaochen47

Assignees
No one assigned
Labels
accepted Accepted the issue
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@tkurylek @cf-gitbot @strehle