Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RND-102 Fix repo removal on exception #161

Merged
merged 1 commit into from
Mar 30, 2023
Merged

RND-102 Fix repo removal on exception #161

merged 1 commit into from
Mar 30, 2023

Conversation

kubama
Copy link
Contributor

@kubama kubama commented Mar 29, 2023 •
edited
Loading

Description

Exception may be thrown when repo directory is not yet created - in this case the logic in finally block was failing. This fixes this issue.

Screenshots / Videos

N/A

Checklist

Tests

Updated unit test

Documentation

N/A

@kubama kubama added bug-fix Pull request with non-breaking change fixing an issue internal Pull request with internal change (e.g. refactoring, CI changes, documentation update) labels Mar 29, 2023
@kubama kubama changed the title RND-102 Fixe repo removal on exception RND-102 Fix repo removal on exception Mar 29, 2023
@kubama kubama requested a review from qooban March 29, 2023 09:25
@kubama kubama merged commit 15df9f3 into master Mar 30, 2023
@kubama kubama deleted the RND-102-fix branch March 30, 2023 08:02
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qooban qooban qooban approved these changes

Assignees
No one assigned
Labels
bug-fix Pull request with non-breaking change fixing an issue internal Pull request with internal change (e.g. refactoring, CI changes, documentation update)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubama @qooban