Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Added common eslint configuration #22

Merged
merged 7 commits into from
Jan 3, 2020
Merged

Conversation

kubama
Copy link
Contributor

@kubama kubama commented Dec 31, 2019

While working on CY-1719 I realized that there is a substantial part of eslint config that would be duplicated across cloudify-ui projects. To address this I introduced a common eslint-common.json file. Once this package is released cloudify-ui projects' eslint configurations will extend this file directly, reducing configuration duplication.
This will also address CY-1547.

@kubama kubama requested a review from qooban December 31, 2019 11:11
Copy link
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Commented.

eslint/README.md Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
eslint/README.md Show resolved Hide resolved
eslint/eslint-common.json Show resolved Hide resolved
eslint/README.md Show resolved Hide resolved
@kubama kubama merged commit defb51e into master Jan 3, 2020
@qooban qooban deleted the CY-1719-eslint-security branch May 21, 2020 10:31
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants