Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

CY-2720 - Final alignments for ESLint configuration #38

Merged
merged 14 commits into from
Oct 19, 2020
Merged

CY-2720 - Final alignments for ESLint configuration #38

merged 14 commits into from
Oct 19, 2020

Conversation

qooban
Copy link
Contributor

@qooban qooban commented Oct 13, 2020

Changes:

  • ESLint
    • Turned off security/detect-non-literal-require rule as it is duplicated by import/no-dynamic-require
    • Added eslint-common-node ESLint configuration
    • Added prettier-common Prettier configuration for all UI projects
    • Added env setup to common ESLint configs
    • Moved ESLint and Prettier configuration files to configs directory
    • Updated eslint* and prettier dependencies
    • Fixed source code and tests after prettier version upgrade
    • Aligned lint script in package.json files with other projects:
      • added --cache switch and added .eslintcache to .gitignore
      • added --ignore-path .gitignore
      • added --max-warnings 10
  • Removed CircleCI from documentation and scripts
  • Fixed security issues by updating dependencies

@qooban qooban requested a review from kubama October 13, 2020 08:21
src/icons.js Outdated Show resolved Hide resolved
@qooban qooban requested a review from kubama October 13, 2020 09:48
@qooban qooban changed the title CY-2720 - Final alignments for ESLint configuration in UI projects CY-2720 - Final alignments for ESLint configuration Oct 15, 2020
@qooban qooban merged commit 6dcf3ba into master Oct 19, 2020
@qooban qooban deleted the CY-2720 branch October 19, 2020 11:54
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants