Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

RD-385 Added backend common modules #39

Merged
merged 8 commits into from
Dec 7, 2020
Merged

RD-385 Added backend common modules #39

merged 8 commits into from
Dec 7, 2020

Conversation

kubama
Copy link
Contributor

@kubama kubama commented Dec 3, 2020

No description provided.

@kubama kubama requested a review from qooban December 3, 2020 14:02
qooban
qooban reviewed Dec 4, 2020
View reviewed changes
Copy link
Contributor

@qooban qooban left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Great changes and significant step towards easier maintenance of common backend areas in Stage and Composer. These tests are awesome. Added some comments. Not all are request for changes.

backend/db.js Show resolved Hide resolved
backend/logger.js Outdated Show resolved Hide resolved
.eslintrc.json Show resolved Hide resolved
backend/documentation.yml Show resolved Hide resolved
backend/logger.js Outdated Show resolved Hide resolved
backend/migration.js Outdated Show resolved Hide resolved
backend/migration.js Outdated Show resolved Hide resolved
package.json Show resolved Hide resolved
package.json Show resolved Hide resolved
backend/test/migration.test.js Show resolved Hide resolved
@kubama kubama requested a review from qooban December 4, 2020 14:54
@kubama kubama merged commit 8d772da into master Dec 7, 2020
@kubama kubama deleted the RD-385-common-backend branch December 7, 2020 07:27
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@qooban qooban qooban approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@kubama @qooban