Properly handle Cloudinary public IDs and extensions for media and raw resources

[newtonjob]

Historically, Cloudinary is known to not play nice with extensions in public ids for media resources. This is so that we can easily transform the resources to various other types for delivering with possible transformations.

When resources are being uploaded, the package currenty removes the extension from the public ID passed to Cloudinary.
This is great, as Cloudinary recommends to not include file extensions in public IDs for media resources, however, they SHOULD be included for raw resources.

https://cloudinary.com/documentation/image_upload_api_reference

This PR solves two problems:

• Removes extensions from media resources public_id but not raw resources.
• Allows other methods on the Storage facade like exists, delete, rename, etc to still work when the public_id is supplied with its extension.

// Assuming the default storage disk is `cloudinary`.

Storage::delete('avatar-1.jpg'); // Works

Storage::delete('avatar-1'); // Still works

// This makes it possible to do this;
$path = $request->file('avatar')->store();

Storage::delete($path);
// Which wasn't possible before this PR.

This way, people can switch storage disks and not make any changes to their code.

• I believe this also fixes Discrepancy file extention between upload and get the file #124

[colbyfayock]

hey @newtonjob, im not familiar enough with Laravel to confidently review this, but i did want to make sure this is taking into consideration that it's possible for someone to have set a public ID with a file extension, though it's not particularly recommended and sometimes may happen accidentally

so if for instance, you strip the file extension of a public ID like myid.jpg where .jpg is part of the ID, it would break

i suspect though that in this case you may be stripping it through the upload lifecycle which may be a bit different and probably more appropriate, but thought id mention this to avoid any potential issues

[newtonjob]

Thanks @colbyfayock. You've got a valid point that it's possible for someone to have accidentally set a public ID with a file extension. But that's not currently possible if they uploaded the resource via the adapter in this package, since it currently does strip the extension before upload. See here:

cloudinary-laravel/src/CloudinaryAdapter.php

Lines 77 to 79 in 716acb2

	$fileExtension = pathinfo($publicId, PATHINFO_EXTENSION);
	$newPublicId = $fileExtension ? substr($publicId, 0, - (strlen($fileExtension) + 1)) : $publicId;

This PR is just making sure that the adapter is consistently stripping the extensions when interacting with other methods like Storage::exists(), Storage::rename(), Storage::delete(), etc.

[colbyfayock]

perfect thanks for confirming @newtonjob 🙏

[unicodeveloper]

Just here to say that I really like this PR. Nice work @newtonjob

[joshmanders]

Thank you, @newtonjob!