fix: programatic text-tracks in Safari

cloudinary · Dec 8, 2024 · 58a1cb1 · 58a1cb1
1 parent 8a896fe
commit 58a1cb1
Show file tree

Hide file tree

Showing 4 changed files with 2 additions and 14 deletions.
diff --git a/src/config/defaults.js b/src/config/defaults.js
@@ -29,6 +29,6 @@ export default {
   allowUsageReport: true,
   playedEventPercents: [25, 50, 75, 100],
   html5: {
-    nativeTextTracks: !videojs?.browser?.IS_SAFARI
+    nativeTextTracks: false
   }
 };
diff --git a/src/plugins/chapters/chapters.js b/src/plugins/chapters/chapters.js
@@ -100,10 +100,6 @@ const ChaptersPlugin = (function () {
         default: true
       });
 
-      // required for Safari to display the captions
-      // https://github.com/videojs/video.js/issues/8519
-      await new Promise(resolve => setTimeout(resolve, 100));
-
       const end = this.player.duration();
       Object.entries(this.options).forEach((entry, index, arr) => {
         const cue = new VTTCue(

diff --git a/src/plugins/paced-transcript/index.js b/src/plugins/paced-transcript/index.js
@@ -64,10 +64,6 @@ function pacedTranscript(config) {
       mode: options.default ? 'showing' : 'disabled'
     });
 
-    // required for Safari to display the captions
-    // https://github.com/videojs/video.js/issues/8519
-    await new Promise(resolve => setTimeout(resolve, 100));
-
     captions.forEach(caption => {
       captionsTrack.track.addCue(new VTTCue(caption.startTime, caption.endTime, caption.text));
     });

diff --git a/src/plugins/srt-text-tracks/srt-text-tracks.js b/src/plugins/srt-text-tracks/srt-text-tracks.js
@@ -27,10 +27,6 @@ function srtTextTracks(config, player) {
       mode: config.default ? 'showing' : 'disabled'
     });
 
-    // required for Safari to display the captions
-    // https://github.com/videojs/video.js/issues/8519
-    await new Promise(resolve => setTimeout(resolve, 100));
-
     // Add the WebVTT data to the track
     webvttCues.forEach(cue => {
       if (cue) {
@@ -47,7 +43,7 @@ function srtTextTracks(config, player) {
 // SRT parser
 const srt2webvtt = data => {
   const SRTParser = new srtParser2();
-  
+
   const cues = SRTParser.fromSrt(data);
 
   return cues.map(cue => ({