me-17956: test if videos on audio player page are playing #762
+55
−0
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
✅ Deploy Preview for cld-video-player ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
✅ Deploy Preview for cld-vp-esm-pages ready!
To edit notification comments on pull requests, go to your Netlify site configuration. |
refael-m
reviewed
Dec 10, 2024
test/e2e/src/pom/audioPlayerPage.ts
Outdated
| import { VideoComponent } from '../../components/videoComponent'; | ||
| import { BasePage } from './BasePage'; | ||
| const AUDIO_PLAYER_FIRST_VIDEO_SELECTOR = '//*[@id="player_html5_api"]'; | ||
| const AUDIO_PLAYER_SECOND_VIDEO_SELECTOR = '//*[@id="player-t_html5_api"]'; |
There was a problem hiding this comment.
can you give it more meaningful names instead of firstVideo, secondVideo?
There was a problem hiding this comment.
changed to audioPlayerVideoComponent and audioPlayerWithTransformationVideoComponent
refael-m
approved these changes
Dec 10, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Relevant task - https://cloudinary.atlassian.net/browse/ME-17956
This test is navigating to audio player page (audio.html) and make sure that 2 videos element are playing (checking that the video is not paused).