Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Version 1.4 breaks uploads with transformations #106

Closed
Airswoop1 opened this issue Jun 22, 2016 · 4 comments
Closed

Version 1.4 breaks uploads with transformations #106

Airswoop1 opened this issue Jun 22, 2016 · 4 comments

Comments

@Airswoop1
Copy link

In the latest version of the repository 1.4, lib/utils.js line 341, there is a check for width.startsWith("auto"). In prior versions <=1.3, the check is width == "auto". The modification to use startsWith expects that the parameter being passed in is a string. If it is a number, (as it was for me), the function throws an unhandled exception.
@Airswoop1
Copy link
Author

@tocker this should probably hotfixed immediately given the severity of the issue

@tikotzky
Copy link

its breaking all calls to cloudinary.image and cloudinary.url as well...
see: #105

@TalLevAmi
Copy link
Contributor

We are working on a fix. Will be released shortly. Sorry about that.

TalLevAmi added a commit that referenced this issue Jun 22, 2016
@TalLevAmi
Fix #105 #106 - url generation broken width numeric width parameter
8b62b03
TalLevAmi added a commit that referenced this issue Jun 22, 2016
@TalLevAmi
Version 1.4.1
b101e3b 
  * Fix #105 #106 - url generation broken width numeric width parameter
@TalLevAmi
Copy link
Contributor

Version 1.4.1 was pushed to npm that solves this issue.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

No branches or pull requests
3 participants
@TalLevAmi @tikotzky @Airswoop1