Add feature to allow override on timestamp and signature #295
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
lukitsbrian
force-pushed
the
feature/allow-override-on-timestamp-and-signature
branch
from
b94ae83 to
39cb8ba
Compare
|
@strausr , let's review and make sure it goes into the next version |
strausr
reviewed
Oct 2, 2019
strausr
reviewed
Oct 2, 2019
strausr
requested changes
Oct 2, 2019
| @@ -1063,6 +1063,8 @@ function process_request_params(params, options) { | |||
| if (options.unsigned != null && options.unsigned) { | |||
| params = exports.clear_blank(params); | |||
| delete params.timestamp; | |||
| } else if (options.signature ) { | |||
| params = exports.clear_blank(options); | |||
There was a problem hiding this comment.
Can you please explain what clear_blank is being used?
There was a problem hiding this comment.
Following the same practice the same as from line#1064
lukitsbrian
force-pushed
the
feature/allow-override-on-timestamp-and-signature
branch
from
105cc07 to
a5334a6
Compare
strausr
approved these changes
Oct 10, 2019
patrick-tolosa
deleted the
feature/allow-override-on-timestamp-and-signature
branch
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
To allow override on timestamp and signature on API call level