Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Allow external PRs to pass Travis tests #407

Merged
merged 1 commit into from
Jun 18, 2020
Merged

Allow external PRs to pass Travis tests #407

Show file tree
Hide file tree
Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
4 changes: 2 additions & 2 deletions test/cloudinary_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -816,7 +816,7 @@ describe("cloudinary", function () {
});
describe("CLOUDINARY_URL", function () {
after(function () {
process.env.CLOUDINARY_URL = cloudinaryUrlBackup;
process.env.CLOUDINARY_URL = cloudinaryUrlBackup || '';
cloudinary.config(true);
});
it("should allow nested values in CLOUDINARY_URL", function () {
Expand Down Expand Up @@ -849,7 +849,7 @@ describe("cloudinary", function () {
});
describe("CLOUDINARY_ACCOUNT_URL", function () {
after(function () {
process.env.CLOUDINARY_ACCOUNT_URL = accountUrlBackup;
process.env.CLOUDINARY_ACCOUNT_URL = accountUrlBackup || '';
cloudinary.config(true);
});
it("should allow nested values in CLOUDINARY_ACCOUNT_URL", function () {
Expand Down
5 changes: 4 additions & 1 deletion test/integration/api/provisioning/account_spec.js
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -6,7 +6,10 @@ const expect = require("expect.js");
const cloudinary = require("../../../../cloudinary");
const TIMEOUT = require('../../../testUtils/testConstants').TIMEOUT;

describe('account API - Provisioning', function () {
let runOnlyForInternalPRs = process.env.TRAVIS_SECURE_ENV_VARS ? describe : describe.skip;


runOnlyForInternalPRs('account API - Provisioning', function () {
let CLOUD_SECRET;
let CLOUD_API;
let CLOUD_NAME;
Expand Down