Dev/update analyze api #495
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Added Travis badge to README
Support multiple resource_types in ZIP generation
The reasoning for this is that if the first expect fails it will not send the other requests, which will pollute our account
This test was a duplicate of line 65 in the same file: 'Accepts credentials as an argument'
(Update video HTML 5 tag to include support for h265 and vp9)
* Refactor in a wait period for eager uploads
Refactor out a duplicate test improve provisioning API tests for GET sub_accounts - Add a test for prefix - Add a test for ids[] in the API Fix prefix name in "update_sub_account" test Improve the atomic-ness of the provisioning test
* updated types for resources promises
* Add types for Structured Metadata functions
* Align all structured metadata tests with reference implementation
* Add `rate_limits` back to responses sent from Admin API
… "$width") (#367) * Fix `normalize_expression` to ignore predefined variables
- Create /testUtils/testConstants - Remove all TIMEOUT constants from spechelper - Fix all imports for other spec files
* Allow external PRs to pass tests using a temporary account
* Add validation to genreate_auth_token to enforce url or acl in the object
* Add an additional option to disable promises in call_api -- disable_promises:bool
patrick-tolosa
commented
Jun 14, 2021
| @@ -302,7 +319,9 @@ function build_upload_params(options) { | |||
| unique_filename: utils.as_safe_bool(options.unique_filename), | |||
| upload_preset: options.upload_preset, | |||
| use_filename: utils.as_safe_bool(options.use_filename), | |||
| analyze: JSON.stringify(options.analyze), | |||
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
This PR merges the branch
analyze_apiwith latest from master, and adds theanalyze: JSON.stringify(options.analyze)key to thebuild_upload_paramsNote:
analyze: JSON.stringify(options.analyze)in the first place.