Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Stabilize metadata tests #530

Merged
merged 1 commit into from
Feb 14, 2022
Merged

Conversation

YomesInc
Copy link
Contributor

@YomesInc YomesInc commented Feb 4, 2022

Brief Summary of Changes

What Does This PR Address?

  • GitHub issue (Add reference - #XX)
  • Refactoring
  • New feature
  • Bug fix
  • Adds more tests

Are Tests Included?

  • Yes
  • No

Reviewer, Please Note:

Some details about changes:

  • Q.all instead of Q.allSettled in before, since there is no reason to continue tests if setup failed
  • metadata creation as a separate call before uploading to avoid potential race conditions
  • retry of test fragments instead of entire tests - to be able to reuse the same approach in tests which upload files as part of the test.

@patrick-tolosa patrick-tolosa merged commit cfe373b into master Feb 14, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants