Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

enable multiple features in analytic tokens #553

Draft
wants to merge 1 commit into
base: master
Choose a base branch
from

Conversation

lbendavid-cloudinary
Copy link
Contributor

Pull request for @cloudinary/url-gen

What does this PR solve?

enable creating feature flags for more than one feature in a single call

Final checklist

  • Implementation is aligned to Spec.
  • Tests - Add proper tests to the added code.

Copy link

@const-cloudinary const-cloudinary left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does it preserve the order how the features where invoked?
I can see from the code that you just add them in a constant order.
As you know order matters.
It can provide useful information, for example when order is wrong or not optimal.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants