Feature/81 refactor global config using k8s registry lib #83
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
The hash is needed as the dogu-op v2 violates the go standards because it did not contain the v2 version in the module name. Therefore an update via 'go mod' or 'go get' is not possible. As the new dogu-op version do not contain the dogu encryption functions anymore, we needed to strip the code from encryptionAdapter.go and delete the tests. This is no problem as this code should be removed anyway because we do not want to encrypt sensitive dogu config ourselves anymore.
… into feature/81-Use-Kubernetes-native-config-options-instead-of-etcd # Conflicts: # go.mod # go.sum
this fixes further problems with the k8s.io/client-go update
We need a wrapper because of our specific errors in the blueprint operator. Maybe we can introduce them in the registry-lib as well, so we can completely remove this wrapper adapter. For now, the plan is to replace the old etcd adapter step by step with the new adapter.
We need a wrapper because of our specific errors in the blueprint operator. Maybe we can introduce them in the registry-lib as well, so we can completely remove this wrapper adapter. For now, the plan is to replace the old etcd adapter step by step with the new adapter.
headers will be sent at the write call already. Calling writeHeader cannot change the status code afterward.
just use SensitiveDoguConfigEntryRepo directly
It was unused and it should also not be used as it hides conflict errors which we need to handle
with the current mockery config they will not be updated automatically with 'make mocks'. I needed to copy the interface into another package to generate the mocks. Then I could copy them on the right place.
Introduce new types so that we can refactor the operator step by step.
alexander-dammeier
force-pushed
the
feature/81-refactor-global-config-using-k8s-registry-lib
branch
from
27f5f4f
to
a4a9c79
Compare
…-of-etcd' into feature/81-refactor-global-config-using-k8s-registry-lib
This includes the linter fixes, previously tested with this operator.
…-of-etcd' into feature/81-refactor-global-config-using-k8s-registry-lib
cesmarvin
reviewed
Oct 11, 2024
| type doguConfigEntryRepository interface { | ||
| domainservice.DoguConfigEntryRepository | ||
| } | ||
|
|
||
| type doguConfigRepository interface { |
There was a problem hiding this comment.
🚫 [checkstyle] reported by reviewdog 🐶
type doguConfigRepository is unused
| type sensitiveDoguConfigEntryRepository interface { | ||
| domainservice.SensitiveDoguConfigEntryRepository | ||
| } | ||
|
|
||
| type configEncryptionAdapter interface { | ||
| domainservice.ConfigEncryptionAdapter | ||
| type sensitiveDoguConfigRepository interface { |
There was a problem hiding this comment.
🚫 [checkstyle] reported by reviewdog 🐶
type sensitiveDoguConfigRepository is unused
Also add tests and go doc
|
We will only merge the third PR #84 which is based on this |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
No description provided.