Skip to content

Commit

Permalink
use parent context without cancel
Browse files Browse the repository at this point in the history
  • Loading branch information
nfranzeck committed May 23, 2024
1 parent b23dbf2 commit a89f66b
Showing 1 changed file with 1 addition and 2 deletions.
3 changes: 1 addition & 2 deletions packages/logging/service.go
Original file line number Diff line number Diff line change
Expand Up @@ -139,8 +139,7 @@ func (s *loggingService) ApplyLogLevelWithRestart(ctx context.Context, req *pb.L
return &emptypb.Empty{}, nil
}

// Decouple grpc-request context from RestartDogu context by creating a new context
if lErr := s.doguRestarter.RestartDogu(context.Background(), doguName); lErr != nil {
if lErr := s.doguRestarter.RestartDogu(context.WithoutCancel(ctx), doguName); lErr != nil {
return nil, createInternalErrWithCtx(fmt.Errorf("unable to restart dogu %s after setting new log level: %w", doguName, lErr), codes.Internal)
}

Expand Down

0 comments on commit a89f66b

Please sign in to comment.