-
Notifications
You must be signed in to change notification settings - Fork 0
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add k8s registry lib #14
Conversation
also delete test as they only use mocks for the deps
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Thank you for your work! 👏 Generally this LGTM, I only found a minor inconsistency in handling the go version in the go.mod
go.mod
Outdated
@@ -1,78 +1,80 @@ | |||
module github.com/cloudogu/k8s-host-change | |||
|
|||
go 1.20 | |||
go 1.22.0 |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Everywhere is go 1.22.4 used except here?
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Toolchain defines the suggested version to be used for this module. I think it is automatically updated because of a dependency used here. However we can adjust the version here.
LGTM |
Resolve #13