This repository has been archived by the owner on Oct 7, 2021. It is now read-only.
[kops/template] Fix kops install hook that installs iptable rule for kiam #49
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
[kops-private-topology.yaml.gotmpl] Fix
kopsinstall hook that installs iptable rule for kiam.why
Although we have not experienced problems with the prior hook,
kopsdoes not actually support anafterclause and we were using the wrongafterclause anyway. This new hook installs a systemd unit that properly waits for the network to come up fully (in particular, we need it to be assigned an IP address) and also gets run before Docker starts bringing up containers.references
This hook is needed to free
kiamfrom the responsibility of managingiptablesitself, which in turn allows for RollingUpdates. See uswitch/kiam#202 and uswitch/kiam#253