-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add atmos docs <component>
command
#751
Add atmos docs <component>
command
#751
Conversation
Caution Review failedThe pull request is closed. 📝 WalkthroughWalkthroughThe changes introduce enhancements to the Changes
Possibly related PRs
Suggested reviewers
Poem
Thank you for using CodeRabbit. We offer it for free to the OSS community and would appreciate your support in helping us grow. If you find it useful, would you consider giving us a shout-out on your favorite social media? 🪧 TipsChatThere are 3 ways to chat with CodeRabbit:
Note: Be mindful of the bot's finite context window. It's strongly recommended to break down tasks such as reading entire modules into smaller chunks. For a focused discussion, use review comments to chat about specific files and their changes, instead of using the PR comments. CodeRabbit Commands (Invoked using PR comments)
Other keywords and placeholders
CodeRabbit Configuration File (
|
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 2
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
⛔ Files ignored due to path filters (1)
go.sum
is excluded by!**/*.sum
📒 Files selected for processing (2)
- cmd/docs.go (1 hunks)
- go.mod (8 hunks)
🔇 Additional comments (2)
go.mod (2)
13-13
: LGTM! Dependencies align well with the PR objectives.
The new dependencies are appropriate for implementing markdown rendering functionality:
github.com/charmbracelet/glamour
for terminal markdown rendering- Supporting dependencies for HTML sanitization, syntax highlighting, and markdown parsing
The changes are well-structured and use stable versions from reputable sources.
Also applies to: 62-62, 89-89, 107-107, 132-132, 174-174, 184-184, 222-223
185-185
: 🧹 Nitpick (assertive)
Consider using a stable version of termenv.
The dependency github.com/muesli/termenv
is using a pre-release version (v0.15.3-0.20240618155329-98d742f6907a
). While this might be required by glamour, consider checking if a stable version would work to avoid potential instability.
Also, please add a note about the new functionality to https://atmos.tools/cli/commands/docs/#usage |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Actionable comments posted: 1
📜 Review details
Configuration used: CodeRabbit UI
Review profile: ASSERTIVE
📒 Files selected for processing (1)
- website/docs/cli/commands/docs.mdx (1 hunks)
🔇 Additional comments (1)
website/docs/cli/commands/docs.mdx (1)
17-18
: LGTM! Clear explanation of the command's dual functionality.
The description effectively communicates both the default behavior and the new component-specific documentation feature.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
@RoseSecurity thanks, LGTM.
Please resolve the conflicts and address the Coderabbit suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM, please address comments
Co-authored-by: Andriy Knysh <aknysh@users.noreply.github.com>
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
thanks @RoseSecurity
atmos docs <component>
functionalityatmos docs <component>
command
These changes were released in v1.98.0. |
what
atmos docs <component>
commandwhy
testing
docs
command is not affectedreferences
Summary by CodeRabbit
New Features
Bug Fixes
Documentation
atmos docs
command to clarify functionality and provide usage examples.Chores