Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Supported the atmos.d, allowing automatic inclusion of configuration files from the atmos.d directory #808
base: main
Are you sure you want to change the base?
Supported the atmos.d, allowing automatic inclusion of configuration files from the atmos.d directory #808
Changes from all commits
892cfeb
052673b
63ffce1
000e439
4493540
d1903c4
d9a3517
089a82f
c020d63
31c844c
d70f66f
512e02e
c22624f
750f4b5
8eeda00
a8d3528
d8a00ef
8050589
52b170d
f85d53e
73d9255
9913b54
cdb9fa1
7090975
3dfb2e0
cdafe20
b702884
8704668
989cd9e
a7414bb
3a24ee6
061ba9c
e57aacb
e6a3200
fa5f25e
86e2505
95cdf74
bc2c4bc
8e6998a
87d4b0f
31d71c1
e64d2eb
378897c
e8d8507
6e4bc4d
930fde6
94e99d6
85957a4
b75c251
a742412
30c82d2
0609a78
1c02902
792ff0a
33da5d0
885bd00
b933331
50cd50e
aafdf16
3bb33fa
a55f6f2
66c0a59
27d3acd
1d46232
9a27195
File filter
Filter by extension
Conversations
Jump to
There are no files selected for viewing
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
STRENGTHEN YOUR DEFENSES WITH SPECIFIC PATTERNS!
The recursive glob pattern
configs.d/**/*
might include unwanted files. Consider being more specific about file extensions.📝 Committable suggestion
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Add configuration examples for atmos.d features.
The file should demonstrate the new features mentioned in the PR objectives, particularly:
Here's a suggested structure:
🧰 Tools
🪛 yamllint (1.35.1)
[error] 5-5: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Clean up file structure.
Remove trailing spaces and normalize empty lines.
🧰 Tools
🪛 yamllint (1.35.1)
[error] 5-5: trailing spaces
(trailing-spaces)
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
💡 Codebase verification
The import statement
catalog/example
doesn't match the actual catalog structure. The catalog directory contains onlystation.yaml
, but noexample.yaml
file.examples/demo-env/stacks/deploy/dev.yaml
referencescatalog/example
station.yaml
Consider either:
catalog/station
to match the existing fileexample.yaml
file in the catalog directory🔗 Analysis chain
WELL STRUCTURED! Let's verify the catalog import.
The import statement follows the new atmos.d convention. However, let's verify the catalog structure.
The previous command failed because the catalog directory wasn't found. Let's first check the directory structure and then look for any example configuration files to understand the correct path.
We found multiple catalog directories, but we need to focus on the one in demo-env since that's where our import statement is located. Let's verify its contents.
🏁 Scripts executed
The following scripts were executed for the analysis:
Script:
Length of output: 130
Script:
Length of output: 649
Script:
Length of output: 314