-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
improve atmos list components
view
#828
Open
pkbhowmick
wants to merge
21
commits into
main
Choose a base branch
from
pulak/DEV-2805
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
+307
−23
Open
Changes from 20 commits
Commits
Show all changes
21 commits
Select commit
Hold shift + click to select a range
c32d12f
improve `atmos list components` view
pkbhowmick 53c74ef
refactor code
pkbhowmick a3fec3d
update unit test
pkbhowmick d192dcf
Update pkg/list/list_components.go
pkbhowmick 382851e
update unit tests
pkbhowmick 6b4f28e
Merge branch 'main' into pulak/DEV-2805
osterman ef8a25d
Merge branch 'main' into pulak/DEV-2805
pkbhowmick 277e5b7
use lipgloss
pkbhowmick 2555c35
refactor code
pkbhowmick bb305d1
improve errro handling
pkbhowmick 2b5cb97
Merge branch 'main' into pulak/DEV-2805
pkbhowmick 964ba87
update table logic
pkbhowmick dafdfc8
Merge branch 'main' into pulak/DEV-2805
pkbhowmick c24bf75
Update pkg/list/list_components.go
pkbhowmick 3b2425d
Merge branch 'main' into pulak/DEV-2805
pkbhowmick 82a8a73
update table color
pkbhowmick 925d0e7
Merge branch 'main' into pulak/DEV-2805
pkbhowmick 2c85549
add abstruct flag
pkbhowmick 1fa0f47
handle TTY
pkbhowmick f368057
calculate width based on data width
pkbhowmick d939c70
Merge branch 'main' into pulak/DEV-2805
osterman File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
Fix undefined
cliConfig
variable.The code is trying to use
cliConfig
which is undefined. You should use theatmosConfig
variable that was initialized earlier.📝 Committable suggestion
🧰 Tools
🪛 GitHub Check: Build (macos-latest, macos)
[failure] 43-43:
undefined: cliConfig
🪛 GitHub Check: Build (ubuntu-latest, linux)
[failure] 43-43:
undefined: cliConfig