-
-
Notifications
You must be signed in to change notification settings - Fork 103
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
feat: Support Relative Path Imports #891
Open
milldr
wants to merge
18
commits into
main
Choose a base branch
from
feat/DEV-1856_relative-paths
base: main
Could not load branches
Branch not found: {{ refName }}
Loading
Could not load tags
Nothing to show
Loading
Are you sure you want to change the base?
Some commits from the old base branch may be removed from the timeline,
and old review comments may become outdated.
Open
Changes from 16 commits
Commits
Show all changes
18 commits
Select commit
Hold shift + click to select a range
c50d071
Handle relative paths for stack imports
milldr f79e16a
Tests for relative paths
milldr 74ab1d8
Refactor handling of relative paths in ProcessImportSection
milldr e2af2db
Handle relative paths in StackImport.Path and string imports
milldr 9d39012
Add new test2/us-west-1.yaml file and update test counts
milldr 12358b0
Update import paths in us-west-1.yaml file
milldr 093ac5e
Merge branch 'main' into feat/DEV-1856_relative-paths
milldr b9856ff
Merge branch 'main' into feat/DEV-1856_relative-paths
osterman 71eaca0
Merge branch 'main' into feat/DEV-1856_relative-paths
milldr 4f6170c
Merge branch 'feat/DEV-1856_relative-paths' of github.com:cloudposse/…
milldr 362e979
Merge branch 'main' into feat/DEV-1856_relative-paths
milldr 8d76059
Refactor handling of import paths in ProcessImportSection
milldr 1beeb8a
Resolve relative paths in ProcessImportSection function
milldr dd55c0f
Update internal/exec/stack_processor_utils.go
milldr dfa5a84
Refactor resolveRelativePath for improved path handling
milldr 507a5dd
Refactor filepath handling for better readability
milldr cafdfdd
Remove unnecessary path normalization code and simplify logic
milldr ddde3d5
Improve path resolution handling in stack_processor_utils
milldr File filter
Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
There are no files selected for viewing
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,8 @@ | ||
# yaml-language-server: $schema=https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json | ||
|
||
vars: | ||
stage: test-2 | ||
|
||
settings: | ||
config: | ||
is_prod: false |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# yaml-language-server: $schema=https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json | ||
|
||
import: | ||
- mixins/stage/test2 | ||
- ../_defaults # validate relative paths |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# yaml-language-server: $schema=https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json | ||
|
||
import: | ||
- mixins/region/us-east-2 | ||
- ./_defaults # validate relative paths |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Original file line number | Diff line number | Diff line change |
---|---|---|
@@ -0,0 +1,5 @@ | ||
# yaml-language-server: $schema=https://atmos.tools/schemas/atmos/atmos-manifest/1.0/atmos-manifest.json | ||
|
||
import: | ||
- path: mixins/region/us-west-1 | ||
- path: ./_defaults # validate relative paths using the `path` field |
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Oops, something went wrong.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
🛠️ Refactor suggestion
Improve path resolution validation in ProcessImportSection
The resolved paths should be validated before being used in imports.
Apply these improvements:
Add this validation helper:
Also applies to: 1808-1808