Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Support for additional policy for creating reserial copies of S3 buckets #89

Merged
merged 6 commits into from
Aug 30, 2024
Merged

Support for additional policy for creating reserial copies of S3 buckets #89

merged 6 commits into from
Aug 30, 2024

Conversation

obervinov
Copy link
Contributor

what

  • Added an additional policy (AWSBackupServiceRolePolicyForS3Backup) to the IAM user being created.
  • This allows the module to be used for creating backups of S3 buckets.

why

  • Backing up S3 buckets was a missing feature necessary to fully cover the backup process through AWS Backup using this module.
  • The IAM user created by this module lacked the additional AWSBackupServiceRolePolicyForS3Backup policy needed for S3 bucket backups.

references

@obervinov obervinov requested review from a team as code owners August 15, 2024 14:16
@obervinov obervinov requested review from hans-d and gberenice August 15, 2024 14:16
@mergify mergify bot added the triage Needs triage label Aug 15, 2024
@begemotik
Copy link

@hans-d @gberenice, do you mind to take some time reviewing it?

@gberenice
Copy link
Contributor

/terratest

gberenice
gberenice approved these changes Aug 30, 2024
View reviewed changes
Copy link
Contributor

@gberenice gberenice left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@gberenice gberenice merged commit 3a019b7 into cloudposse:main Aug 30, 2024
15 checks passed
@mergify mergify bot removed the triage Needs triage label Aug 30, 2024
@github-actions GitHub Actions
Copy link
Contributor

These changes were released in v1.0.2.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@gberenice gberenice gberenice approved these changes

@hans-d hans-d Awaiting requested review from hans-d hans-d is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@obervinov @begemotik @gberenice