Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Upgrade s3-log-storage dependency to 1.0.0 #68

Closed
ghost opened this issue Dec 27, 2022 · 1 comment
Closed

Upgrade s3-log-storage dependency to 1.0.0 #68

ghost opened this issue Dec 27, 2022 · 1 comment
Labels
bug 🐛 An issue with the system

Comments

@ghost
Copy link

ghost commented Dec 27, 2022

Found a bug? Maybe our Slack Community can help.

Slack Community

Describe the Bug

Using this module introduces a deprecation message regarding the use of "versioning" attribute of the s3 bucket created by this module.

Expected Behavior

No deprecation messages appear when using the latest release of this module

Steps to Reproduce

module "cloudtrail_s3_bucket" {
  source  = "cloudposse/cloudtrail-s3-bucket/aws"
  version = "0.23.1"
}

Screenshots

╷
│ Warning: Argument is deprecated
│ 
│   with module.cloudtrail_s3_bucket.module.s3_bucket.aws_s3_bucket.default[0],
│   on .terraform/modules/cloudtrail_s3_bucket.s3_bucket/main.tf line 1, in resource "aws_s3_bucket" "default":
│    1: resource "aws_s3_bucket" "default" {
│ 
│ Use the aws_s3_bucket_versioning resource instead
│ 
│ (and 4 more similar warnings elsewhere)

Environment (please complete the following information):

Anything that will help us triage the bug will help. Here are some ideas:
MacOS 11.7.1
Terraform 1.2.7

Additional Context

This can be fixed by incrementing the version of the depedency "cloudposse/s3-log-bucket" to 1.0.0 (to get AWS v4 provider support). It is possible that an interim version might also work but the release notes for your own module say not to use non 1.0 releases of s3-log-bucket.

@ghost ghost added the bug 🐛 An issue with the system label Dec 27, 2022
@Nuru
Copy link
Contributor

Nuru commented May 22, 2024

Closed by #67

@Nuru Nuru closed this as completed May 22, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
bug 🐛 An issue with the system
Projects
None yet
Development

No branches or pull requests

1 participant