-
-
Notifications
You must be signed in to change notification settings - Fork 61
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Update Terraform cloudposse/s3-log-storage/aws to v1 #67
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
renovate
bot
force-pushed
the
renovate/cloudposse-s3-log-storage-aws-1.x
branch
from
May 16, 2023 00:06
fda5300
to
dc6f864
Compare
Edited/Blocked NotificationRenovate will not automatically rebase this PR, because it does not recognize the last commit author and assumes somebody else may have edited the PR. You can manually request rebase by checking the rebase/retry box above. ⚠ Warning: custom changes will be lost. |
/test all |
Nuru
previously approved these changes
May 16, 2023
/test all |
1 task
Nuru
approved these changes
May 16, 2023
This was referenced May 16, 2023
This was referenced May 22, 2024
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Labels
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Note
This PR contains the following updates:
0.26.0
->1.3.1
Release Notes
cloudposse/terraform-aws-s3-log-storage
v1.3.1
Compare Source
🚀 Enhancements
Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @renovate (#88)
This PR contains the following updates:
3.1.0
->3.1.1
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1
Compare Source
🐛 Bug Fixes
Revert change to Transfer Acceleration from #​178 @​Nuru (#​180)
what
why
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.1 (master) @renovate (#88)
This PR contains the following updates:
3.1.0
->3.1.1
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.1
Compare Source
🐛 Bug Fixes
Revert change to Transfer Acceleration from #​178 @​Nuru (#​180)
what
why
v1.3.0
Compare Source
🚀 Enhancements
Enhance lifecycle object with optionals, limit length of bucket name @Nuru (#87)
what
lifecycle_configuration_rules
to be fully defined with optional memberswhy
references
v1.2.0
: Support new AWS S3 defaults (ACL prohibited)Compare Source
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3.1.0 @renovate (#85)
This PR contains the following updates:
3.0.0
->3.1.0
Release Notes
cloudposse/terraform-aws-s3-bucket
v3.1.0
Compare Source
Make compatible with new S3 defaults. Add user permissions boundary. @​Nuru (#​178)
what
aws_s3_bucket_accelerate_configuration
andaws_s3_bucket_versioning
resources even when the feature is disabled, to enable drift detectionwhy
references
Always include `aws_s3_bucket_versioning` resource @​mviamari (#​172)
what
aws_s3_bucket_versioning
resource to track changes made to bucket versioning configurationwhy
aws_s3_bucket_versioning
, the expectation is that the bucket versioning is disabled/suspend for the bucket. If bucket versioning is turned on outside of terraform (e.g. through the console), the change is not detected by terraform unless theaws_s3_bucket_versioning
resource exists.references
Add support for permission boundaries on replication IAM role @​mchristopher (#​170)
what
why
references
🤖 Automatic Updates
Update README.md and docs @​cloudpossebot (#​164)
what
This is an auto-generated PR that updates the README.md and docs
why
To have most recent changes of README.md and doc from origin templates
v1.1.0
Compare Source
Adding "object_lock_configuration" variable @ramses999 (#84)
what
Adding "object_lock_configuration" variable which is used in module "cloudposse/s3-bucket/aws"
why
Must be able to use the Object Lock option for S3 in this module
references
https://github.com/cloudposse/terraform-aws-s3-bucket/blob/6837ed7b2f2460043d6be3981f16ed90563fd12a/main.tf#L5
v1.0.0
Compare Source
Important Notes
bucket_key_enabled
flag defaults tofalse
for backward compatibility. At one point we recommend setting it to true for significant savings on KMS usage, but since bucket keys are only reused within a user session, it is not clear if it provides any savings at all. See AWS docs for more information.lifecycle_configuration_rules
input replaces the now deprecated individual inputs for individual settings of a single lifecycle rule. See the terraform-aws-s3-bucket documentation for details on how to specify lifecycles usinglifecycle_configuration_rules
. This mechanism is much more flexible and closely follows the Terraformaws_s3_bucket_lifecycle_configuration
resource.source_policy_documents
input replaces the now deprecatedpolicy
input to match changes to theaws_iam_policy_document
resourcenull
force_destroy
at its default value offalse
, and if you have it set totrue
but want extra safety against the S3 bucket being destroyed, set it tofalse
before upgrading).force_destroy_enabled
flag introduced in v0.27.0 has been removedlifecycle_configuration_rules
input was introduced. In that version, you would continue to get the old default lifecycle rule even if you supplied new rules vialifecycle_configuration_rules
. Now, the default behavior is to ignore all the deprecated lifecycle inputs when thelifecycle_configuration_rules
input is not empty, unless you explicitly setlifecycle_rule_enabled
to true.Enhancements
Automate upgrade using `moved` blocks @Nuru (#81)
what
moved
block functionality introduced in Terraform 1.3.0nullable = false
for module input variables which have a default value and where null is not a sensible/handled value for the variable.why
null
, closes #63v0.28.3
: Not recommended, use v0.26.0 or v1.x insteadCompare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v3 @renovate (#78)
This PR contains the following updates:
2.0.1
->3.0.0
v0.28.2
: Action required if updating from prior to v0.28.0Compare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.
We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v2.0.1 @renovate (#76)
This PR contains the following updates:
2.0.0
->2.0.1
v0.28.1
: accidental release, do not useCompare Source
v0.28.0 introduced breaking changes with high risk of permanent data loss. See release notes there. This is only a safe upgrade if upgrading from v0.28.0.
We will convert to semantic versioning (incrementing the major version number for breaking changes), but having missed the opportunity to do that for earlier versions of this module, we are waiting for the next major change, expected to be soon after Terraform v1.3 is released.
git.io->cloudposse.tools update @dylanbannon (#73)
what and why
Change all references to
git.io/build-harness
intocloudposse.tools/build-harness
, sincegit.io
redirects will stop working on April 29th, 2022.References
🤖 Automatic Updates
Update Terraform cloudposse/s3-bucket/aws to v2 @renovate (#72)
This PR contains the following updates:
0.49.0
->2.0.3
v0.28.0
: (Action Needed) Support AWS v4 providerCompare Source
WARNING, DATA LOSS LIKELY if you do not follow upgrade instructions:
🚀 Enhancements
Support AWS v4 provider @Nuru (#71)
what
null-label
force_destroy_enabled
why
references
v0.27.0
: (WARNING: Potential Data Loss) Prepare for AWS provider v4Compare Source
Update: This version no longer recommended
With the release of version 1.0.0 of this module, use of this version is no longer recommended. When you are able to use Terraform v1.3.0 or later and Terraform AWS provider v4.9.0 or later, upgrade directly to v1.0.0 or later of this module.
Warning: Potential total data loss
This release is a refactoring in preparation for supporting Terraform AWS Provider v4. One feature was removed, but otherwise there are no changes to inputs or behavior. However, the Terraform "addresses" of resources have changed, so you are need to run several
terraform state mv
commands.Warning: failure to run the required
terraform state mv
commands will cause Terraform to delete your existing S3 bucket and create a new one, deleting all the data stored in the bucket in the process.Details on how to safely upgrade are in this repository's Wiki here
Support for "MFA delete" removed
In #54 a contributor added support for MFA delete via the
versioning_mfa_delete_enabled
. In AWS provider version 3.x this argument was documented with the caveatWith AWS provider version 4.0, this argument now does toggle the setting. Unfortunately, that adds the requirement then when it is enabled, you must supply a current MFA token every time you run
terraform apply
. That is not compatible with automation, and therefore we have no intention to support it and have removed theversioning_mfa_delete_enabled
input.🚀 Enhancements
Refactor to use s3-bucket module, update in general @Nuru (#66)
what
mfa_delete
< 4.0
and disable Renovate bot, closes #64why
mfa_delete
enabled requires entering an MFA token for every Terraform operation, which is incompatible with automation. Users requiringmfa_delete
should either not use Terraform or create their own fork.notes
This is the first of 2 upgrade releases to get this module to support Terraform AWS Provider v4. We are breaking it into 2 releases so that users have the option of upgrading step-by-step rather than all at once. Upgrade instructions are here.
Cleanups and safety checks for upgrade @Nuru (#70)
what
force_destroy
istrue
why
force_destroy
istrue
then an automated, unattended process could cause the S3 bucket to be deleted and all data in it irretrievably lostreferences
Closes Renovate PRs:
build-harness
)Configuration
📅 Schedule: Branch creation - At any time (no schedule defined), Automerge - At any time (no schedule defined).
🚦 Automerge: Disabled by config. Please merge this manually once you are satisfied.
♻ Rebasing: Whenever PR becomes conflicted, or you tick the rebase/retry checkbox.
🔕 Ignore: Close this PR and you won't be reminded about this update again.
This PR has been generated by Mend Renovate. View repository job log here.