Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add requested inputs #111

Merged
merged 9 commits into from
Jun 21, 2022
Merged

Add requested inputs #111

merged 9 commits into from
Jun 21, 2022

Conversation

nitrocode
Copy link
Member

@nitrocode nitrocode commented Jun 21, 2022

@nitrocode nitrocode requested review from a team as code owners June 21, 2022 01:14
@nitrocode nitrocode requested review from dotCipher and brcnblc and removed request for a team June 21, 2022 01:14
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Bridgecrew has found infrastructure configuration errors in this PR ⬇️

main.tf Show resolved Hide resolved
main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to c1340d9 - Auto Format - 1 error was fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_78 Fixed /main.tf module.codebuild.aws_codebuild_project.default

@@ -469,4 +470,15 @@ resource "aws_codebuild_project" "default" {
}
}
Copy link

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

MEDIUM   Ensure that CodeBuild projects are encrypted
    Resource: module.codebuild.aws_codebuild_project.default | ID: BC_AWS_GENERAL_78

How to Fix

resource "aws_codebuild_project" "example" {
  ...
+ encryption_key = "AWS_Key_Management_Service_example"
}

Description

TBD

🎉   Fixed by commit b1ef610 - Add encryption_key

Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to b1ef610 - Add encryption_key - 2 errors were fixed.

Change details

Error ID Change Path Resource
BC_AWS_GENERAL_78 Fixed /main.tf aws_codebuild_project.default
BC_AWS_GENERAL_78 Fixed /main.tf module.codebuild.aws_codebuild_project.default

@nitrocode
Copy link
Member Author

/test all

main.tf Show resolved Hide resolved
Copy link

@bridgecrew bridgecrew bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

⚠️   Due to ce35678 - Add s3_cache_bucket_name - 3 new errors were added

Change details

Error ID Change Path Resource
BC_AWS_NETWORKING_52 Added /main.tf aws_s3_bucket.cache_bucket
BC_AWS_GENERAL_56 Added /main.tf aws_s3_bucket.cache_bucket
BC_AWS_GENERAL_72 Added /main.tf aws_s3_bucket.cache_bucket

@nitrocode
Copy link
Member Author

/test all

@nitrocode
Copy link
Member Author

/test all

@nitrocode nitrocode changed the title Add file_system_locations Add requested inputs Jun 21, 2022
Copy link

@jamengual jamengual left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@nitrocode nitrocode merged commit 9a5a34f into master Jun 21, 2022
@nitrocode nitrocode deleted the file_system_locations branch June 21, 2022 20:11
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
3 participants