Integrated the changes from dome9 #86
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
bcoddens
requested review from
jamengual and
dotCipher
and removed request for
a team
jamengual
previously approved these changes
Mar 16, 2021
main.tf
Outdated
| @@ -367,6 +367,23 @@ resource "aws_codebuild_project" "default" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "secondary_sources" { | |||
| iterator = secondary_source | |||
| for_each = length(var.secondary_sources) > 0 ? var.secondary_sources : [] | |||
There was a problem hiding this comment.
you can delete the condition and it will null if secondary sources is empty
There was a problem hiding this comment.
Changed pushed, is this what you mean ?
added 2 commits
March 16, 2021 20:37
jamengual
previously approved these changes
Mar 16, 2021
main.tf
Outdated
| @@ -367,6 +367,22 @@ resource "aws_codebuild_project" "default" { | |||
| } | |||
| } | |||
|
|
|||
| dynamic "secondary_sources" { | |||
| for_each = var.secondary_sources ? [""] : [] | |||
There was a problem hiding this comment.
you can just do for_each = var.secondary_sources
jamengual
previously approved these changes
Mar 16, 2021
|
/test all |
|
/test all |
…rm-aws-codebuild into secondarysource
…rm-aws-codebuild into secondarysource
|
/test all |
jamengual
approved these changes
Mar 16, 2021
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
What
Our codebuild environment needs double sources as input to build
Why
We use code that is based on gitlab , gitlab is not supported by codebuild so we need to upload zip files to support our codebuilds. We want to keep the config and source in a different upload.
These changes support using multiple s3 buckets as source
References
https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/codebuild_project#secondary_sources
Proceed on pull request: #73