Scaling policy type does not support all its possible values

[james64]

Describe the Bug

Module has variables scale_up_policy_type and scale_down_policy_type. According to documentation they support all values allowed in autoscaling_policy tf resource namely SimpleScaling, StepScaling and TargetTrackingScaling. On the other hand implementation of scaling policies does not contain blocks step_adjustments and target_tracking_configuration which are necessary to use StepScaling or TargetTrackingScaling respectively. This means that effectively only SimpleScaling is available.

Expected Behavior

Option A - support SimpleScaling

• Drop variables scale_*_policy_type and replace them with hardcoded SimpleScaling
• Explicit description of this in readme

Option B - full support for all three policies

[nitrocode]

That makes sense.

Option B makes the most sense to me. If you have some free time, please feel free to contribute 🙏

[Nuru]

@james64 Thank you for bringing this to our attention.

For now, we are going to document that only SimpleScaling is supported, but we will leave the variables (with default values) to leave room for future enhancements and to not break existing modules that set them.

We will accept a PR that adds support for the other scaling types if it includes examples of them in the examples/complete test.