Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Fix conditional logic for creating IAM role #80

Merged
merged 2 commits into from
Jul 9, 2021
Merged

Fix conditional logic for creating IAM role #80

merged 2 commits into from
Jul 9, 2021

Conversation

korenyoni
Copy link
Member

@korenyoni korenyoni commented Jul 9, 2021 •
edited
Loading

what

  • Fix conditional logic for creating IAM role
  • Bump modules in examples/complete.

why

  • IAM Role was being created even when var.enabled=false

references

@korenyoni korenyoni requested review from a team as code owners July 9, 2021 17:00
@korenyoni korenyoni requested review from Gowiem and SweetOps July 9, 2021 17:00
@korenyoni
Copy link
Member Author

/test all

@korenyoni korenyoni added the bug 🐛 An issue with the system label Jul 9, 2021
@korenyoni korenyoni merged commit adb1ac4 into master Jul 9, 2021
@korenyoni korenyoni deleted the fix/instance-profile-logic branch July 9, 2021 17:11
This was referenced Jul 9, 2021
Merged
Merged
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem

@SweetOps SweetOps Awaiting requested review from SweetOps

Assignees
No one assigned
Labels
bug 🐛 An issue with the system
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@korenyoni @nitrocode @cloudpossebot