feat: adds ignore changes on load balancer option #200
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hello 👋 @srhopkins @korenyoni can you please review this PR ? ;) Regards |
jbrt
changed the title
Update from CloudPosse repo
|
/terratest |
|
@jbrt Hi, can you update the pr so that it passes the tests? otherwise, it is likely to be closed due to staleness. |
|
Thanks @jbrt for creating this pull request! A maintainer will review your changes shortly. Please don't be discouraged if it takes a while. While you wait, make sure to review our contributor guidelines. Tip Need help or want to ask for a PR review to be expedited?Join us on Slack in the |
…nd_desired_count_and_load_balancer
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
Adds a new input variable
ignore_changes_load_balancer.why
When using this module within an AWS CodeDeploy Blue/Green deployment context, we need a way to ignore changes related to Load Balancers / Target Groups to avoid any drift. That's why the PR adds a
ignore_changes_load_balancerinput variable.references
Cloudposse's TF modules used for testing:
https://registry.terraform.io/modules/cloudposse/ecs-alb-service-task/aws/latest
https://registry.terraform.io/modules/cloudposse/alb/aws/latest
https://registry.terraform.io/modules/cloudposse/code-deploy/aws/latest