Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

feat: add pid and ipc mode to task def #206

Merged
merged 6 commits into from
Aug 1, 2023

Conversation

dudymas
Copy link
Contributor

@dudymas dudymas commented Jul 31, 2023

what

  • add ipc_mode
  • add pid_mode

why

  • support host level access for monitoring processes

@dudymas dudymas requested review from a team as code owners July 31, 2023 13:55
@dudymas dudymas requested review from dotCipher and woz5999 July 31, 2023 13:55
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
variables.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
Copy link
Member

@milldr milldr left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Please resolve failing checks

Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

terraform fmt -recursive

outputs.tf|72|
outputs.tf|77|

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
Copy link

@github-actions github-actions bot left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Remaining comments which cannot be posted as a review comment to avoid GitHub Rate Limit

tflint

outputs.tf|52 col 103| List items should be accessed using square brackets
outputs.tf|57 col 47| List items should be accessed using square brackets
outputs.tf|62 col 56| List items should be accessed using square brackets
outputs.tf|67 col 57| List items should be accessed using square brackets
outputs.tf|72 col 57| List items should be accessed using square brackets
outputs.tf|77 col 57| List items should be accessed using square brackets

main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
main.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
outputs.tf Outdated Show resolved Hide resolved
@milldr
Copy link
Member

milldr commented Aug 1, 2023

/terratest

@dudymas
Copy link
Contributor Author

dudymas commented Aug 1, 2023

/terratest

@dudymas dudymas enabled auto-merge (squash) August 1, 2023 00:53
@dudymas dudymas merged commit 474902c into main Aug 1, 2023
@dudymas dudymas deleted the feat/task_def/add-ipc-and-pid-mode branch August 1, 2023 00:56
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

2 participants