Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

feat: adds support for track_latest #246

Merged
merged 2 commits into from
Jul 22, 2024
Merged

feat: adds support for track_latest #246

merged 2 commits into from
Jul 22, 2024

Conversation

gberenice
Copy link
Contributor

@gberenice gberenice commented Jul 22, 2024 •
edited by Gowiem
Loading

what

why

  • Allow users to make the task definitions track always the latest one if track_latest is set to true.

references

@gberenice gberenice requested review from a team as code owners July 22, 2024 17:00
@gberenice
Copy link
Contributor Author

/terratest

@mergify mergify bot added the triage Needs triage label Jul 22, 2024
Gowiem
Gowiem previously approved these changes Jul 22, 2024
View reviewed changes
Copy link
Member

@Gowiem Gowiem left a comment •
edited
Loading

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sweet, LGTM!

@mergify mergify bot removed the triage Needs triage label Jul 22, 2024
Gowiem
Gowiem reviewed Jul 22, 2024
View reviewed changes
versions.tf Outdated Show resolved Hide resolved
@Gowiem Gowiem added enhancement New feature or request major Breaking changes (or first stable release) feature New functionality labels Jul 22, 2024
@Gowiem
Copy link
Member

Gowiem commented Jul 22, 2024

/terratest

Benbentwo
Benbentwo reviewed Jul 22, 2024
View reviewed changes
Copy link
Member

@Benbentwo Benbentwo left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM, though curious - similar to @Gowiem - is there a need for TF 1.3+ or was that just to bump up the version.

I think if there's a need lets do it - otherwise we should probably keep it lowest possible version so that we don't force upgrades (even though 0.14.0 is pretty old)

@Gowiem
Copy link
Member

Gowiem commented Jul 22, 2024

/terratest

@gberenice
Copy link
Contributor Author

/terratest

@gberenice
Copy link
Contributor Author

Reverted TF bump due to community concerns (see also the Slack thread).

@Gowiem Gowiem added minor New features that do not break anything and removed major Breaking changes (or first stable release) labels Jul 22, 2024
@Gowiem Gowiem enabled auto-merge (squash) July 22, 2024 20:56
@Gowiem Gowiem merged commit ddd413c into cloudposse:main Jul 22, 2024
35 checks passed
@github-actions GitHub Actions
Copy link

These changes were released in v0.76.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Benbentwo Benbentwo Benbentwo left review comments

@Gowiem Gowiem Gowiem approved these changes

@johncblandii johncblandii Awaiting requested review from johncblandii johncblandii is a code owner automatically assigned from cloudposse/contributors

@jamengual jamengual Awaiting requested review from jamengual jamengual is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
enhancement New feature or request feature New functionality minor New features that do not break anything
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

Add support of track_latest for aws_ecs_task_definition resource
3 participants
@gberenice @Gowiem @Benbentwo