Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Add random attribute to avoid codepipeline bucket name collisions #102

Merged
merged 4 commits into from
Oct 19, 2022
Merged

Add random attribute to avoid codepipeline bucket name collisions #102

merged 4 commits into from
Oct 19, 2022

Conversation

joe-niland
Copy link
Member

what

  • Adds a random string to the codepipeline module's attributes to provide a unique name for the codepipeline bucket

why

  • Automated tests sometimes fail due to bucket naming collisions (presumably when a previous test run failed and was not properly cleaned up)

references

  • None

@joe-niland joe-niland requested review from a team as code owners October 14, 2022 09:56
@cloudpossebot cloudpossebot requested a review from a team as a code owner October 14, 2022 09:57
@joe-niland
Copy link
Member Author

/test terratest

@joe-niland
Copy link
Member Author

/test terratest

@joe-niland
Copy link
Member Author

/test readme

@joe-niland
Copy link
Member Author

/test bats

@joe-niland joe-niland mentioned this pull request Oct 14, 2022
Merged
@joe-niland joe-niland added the patch A minor, backward compatible change label Oct 14, 2022
@joe-niland joe-niland self-assigned this Oct 14, 2022
@nitrocode nitrocode added no-release Do not create a new release (wait for additional code changes) and removed patch A minor, backward compatible change labels Oct 19, 2022
@nitrocode nitrocode merged commit 6e6e437 into cloudposse:master Oct 19, 2022
@joe-niland joe-niland deleted the test-add-random-attr branch October 19, 2022 06:45
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@nitrocode nitrocode nitrocode approved these changes

@jamengual jamengual jamengual approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem was automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni was automatically assigned from cloudposse/contributors

Assignees

@joe-niland joe-niland

Labels
no-release Do not create a new release (wait for additional code changes)
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
4 participants
@joe-niland @jamengual @nitrocode @cloudpossebot