-
-
Notifications
You must be signed in to change notification settings - Fork 150
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
Add bitbucket support #34
Add bitbucket support #34
Conversation
It's okay - it's been requested a lot. Cloud Posse can't support it, but we can accept the contribution! |
@joe-niland looks like we have some merge conflicts |
@osterman this should be OK now. I'm not sure if I agree with defaulting the cache to S3 but I left it in from upstream. I ran the tests locally but got stuck on the terraform-docs ones. Is there a guide/doc about testing? I didn't get the time to dig into it yet. |
If not set to S3 many of our other modules will fail the tests, that is why it defaults to S3. |
/test all |
@jamengual thanks for explaining |
/rebuild-readme |
/test all |
I needed to add Bitbucket support for CodePipeline so this is my attempt.
I'm not sure if you want to add it since you may only want to support GitHub.
For now I also duplicated the CodePipeline resource block but I think it could be done with a single block and dynamic.
Let me know your thoughts.