Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add bitbucket support #34

Merged
merged 6 commits into from
Jun 25, 2020
Merged

Add bitbucket support #34

merged 6 commits into from
Jun 25, 2020

Conversation

joe-niland
Copy link
Member

@joe-niland joe-niland commented May 27, 2020

I needed to add Bitbucket support for CodePipeline so this is my attempt.
I'm not sure if you want to add it since you may only want to support GitHub.

For now I also duplicated the CodePipeline resource block but I think it could be done with a single block and dynamic.

Let me know your thoughts.

@osterman
Copy link
Member

It's okay - it's been requested a lot. Cloud Posse can't support it, but we can accept the contribution!

@joe-niland joe-niland marked this pull request as ready for review June 11, 2020 04:13
@osterman
Copy link
Member

@joe-niland looks like we have some merge conflicts

@joe-niland
Copy link
Member Author

@osterman this should be OK now. I'm not sure if I agree with defaulting the cache to S3 but I left it in from upstream.

I ran the tests locally but got stuck on the terraform-docs ones. Is there a guide/doc about testing? I didn't get the time to dig into it yet.

@jamengual
Copy link
Contributor

jamengual commented Jun 25, 2020

@osterman this should be OK now. I'm not sure if I agree with defaulting the cache to S3 but I left it in from upstream.

I ran the tests locally but got stuck on the terraform-docs ones. Is there a guide/doc about testing? I didn't get the time to dig into it yet.

If not set to S3 many of our other modules will fail the tests, that is why it defaults to S3.

@jamengual
Copy link
Contributor

/test all

@joe-niland
Copy link
Member Author

@osterman this should be OK now. I'm not sure if I agree with defaulting the cache to S3 but I left it in from upstream.

I ran the tests locally but got stuck on the terraform-docs ones. Is there a guide/doc about testing? I didn't get the time to dig into it yet.

If not set to S3 many of our other modules will fail the tests, that is why it defaults to S3.

@jamengual thanks for explaining

@jamengual
Copy link
Contributor

/rebuild-readme

@jamengual
Copy link
Contributor

/test all

@jamengual jamengual merged commit 524844c into cloudposse:master Jun 25, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

4 participants