Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Allow providing CodeBuild VPC config; fix CodePipeline outputs #74

Merged
merged 9 commits into from
Apr 22, 2021
Merged

Allow providing CodeBuild VPC config; fix CodePipeline outputs #74

merged 9 commits into from
Apr 22, 2021

Conversation

joe-niland
Copy link
Member

@joe-niland joe-niland commented Apr 20, 2021 •
edited
Loading

what

  • Allow providing vpc_config object for CodeBuild
  • Fix outputs so they include either CodePipeline resource created (either Github or Bitbucket variant)
  • Added output of entire CodePipeline resource

why

  • There was no way to provide VPC config to the CodeBuild project created by this module
  • Previously only the Github variant of the ECS CodePipeline was output
  • Added output of entire CodePipeline resource so it can be used with modules such as kjagiello/terraform-aws-codepipeline-slack-notifications

references

  • None

@joe-niland joe-niland requested review from a team as code owners April 20, 2021 04:26
@joe-niland joe-niland changed the title Disable repo path condition in codestar policy Fixes: CodeStar policy, VPC config, outputs Apr 20, 2021
@joe-niland joe-niland requested a review from a team as a code owner April 20, 2021 04:27
@joe-niland joe-niland requested review from Makeshift and brcnblc April 20, 2021 04:27
@joe-niland
Copy link
Member Author

/test all

@joe-niland joe-niland changed the title Fixes: CodeStar policy, VPC config, outputs Allow providing CodeBuild VPC config; fix CodePipeline outputs Apr 21, 2021
@joe-niland
Copy link
Member Author

/test all

osterman
osterman reviewed Apr 21, 2021
View reviewed changes
outputs.tf
@@ -51,10 +55,15 @@ output "codebuild_badge_url" {

output "codepipeline_id" {
description = "CodePipeline ID"
value = join("", aws_codepipeline.default.*.id)
value = lookup(local.codepipeline_resource, "id", "")
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Are you sure this is equivalent? What happens with lookup is called on null?

Copy link
Member Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

you're right - null is an invalid input to lookup(). Using a fallback value of {} in the try at the top (instead of null) seems to work OK.

@joe-niland
Copy link
Member Author

/test all

@joe-niland joe-niland merged commit 25a7569 into cloudposse:master Apr 22, 2021
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@brcnblc brcnblc Awaiting requested review from brcnblc

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-niland @osterman @cloudpossebot