Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

[BREAKING CHANGE] support type attribute for CodeBuild environment vars #77

Merged
merged 5 commits into from
Apr 27, 2021
Merged

[BREAKING CHANGE] support type attribute for CodeBuild environment vars #77

merged 5 commits into from
Apr 27, 2021

Conversation

joe-niland
Copy link
Member

what

  • [BREAKING CHANGE] modify environment_variables variable to support the 'type' key

why

  • The CodeBuild module used by this one now supports the 'type' attribute
  • Adding the 'type' attribute allows sourcing env vars from SSM Parameter Store and Secrets Manager

references

  • None

@joe-niland joe-niland requested review from a team as code owners April 22, 2021 23:30
@joe-niland joe-niland requested review from Makeshift and woz5999 April 22, 2021 23:30
@joe-niland
Copy link
Member Author

/test all

@mergify
Copy link

mergify bot commented Apr 22, 2021

This pull request is now in conflict. Could you fix it @joe-niland? 🙏

@joe-niland
Copy link
Member Author

@Gowiem this is a complementary PR to cloudposse/terraform-aws-codebuild#88

@joe-niland
Copy link
Member Author

/rebuild-readme

@joe-niland
Copy link
Member Author

/test all

@joe-niland
Copy link
Member Author

/test terratest

@joe-niland
Copy link
Member Author

/test all

@joe-niland
Copy link
Member Author

/test terratest

@joe-niland joe-niland requested a review from Gowiem April 23, 2021 01:32
@Gowiem Gowiem merged commit 87fb128 into cloudposse:master Apr 27, 2021
@joe-niland joe-niland mentioned this pull request Apr 27, 2021
Closed
1 task
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@Makeshift Makeshift Awaiting requested review from Makeshift

@woz5999 woz5999 Awaiting requested review from woz5999

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@joe-niland @Gowiem @cloudpossebot