Switch s3 bucket to module #91
Closed
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
nitrocode
previously approved these changes
Mar 3, 2022
|
/test all |
kevcube
changed the title
|
@nitrocode I have updated the PR title, description and purpose |
nitrocode
approved these changes
May 18, 2022
|
/test all |
nitrocode
reviewed
May 18, 2022
| @@ -6,9 +6,12 @@ module "codepipeline_label" { | |||
| context = module.this.context | |||
| } | |||
|
|
|||
| resource "aws_s3_bucket" "default" { | |||
| module "artifact_store_bucket" { | |||
There was a problem hiding this comment.
Hmmm this is a bit of scope creep. I don't think we want to use the s3 bucket module in this PR. Let's keep that separated.
nitrocode
changed the title
|
This pull request is now in conflict. Could you fix it @kevcube? 🙏 |
mergify
bot
dismissed
nitrocode’s stale review
This Pull Request has been updated, so we're dismissing all reviews.
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
what
resourcetomoduleto fix tests (aws provider v4)