Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

chore: add load_balancing_algorithm_type variable #236

Merged
merged 5 commits into from
Apr 10, 2024
Merged

chore: add load_balancing_algorithm_type variable #236

merged 5 commits into from
Apr 10, 2024

Conversation

dmitrijn
Copy link
Contributor

@dmitrijn dmitrijn commented Sep 18, 2023 •
edited
Loading

what

  • add load_balancing_algorithm_type variable for alb-ingress module

why

  • allow to switch between round_robin and least_outstanding_requests for alb target groups

@dmitrijn dmitrijn requested review from a team as code owners September 18, 2023 13:42
@Gowiem
Copy link
Member

Gowiem commented Sep 18, 2023

/terratest

@Gowiem
Copy link
Member

Gowiem commented Sep 18, 2023

@dmitrijn mind looking into the various failures?

@dmitrijn
Copy link
Contributor Author

@Gowiem please run tests

@Gowiem
Copy link
Member

Gowiem commented Sep 19, 2023

/terratest

@dmitrijn
Copy link
Contributor Author

dmitrijn commented Sep 20, 2023 •
edited
Loading

@Gowiem it's not possible to run tests on terraform v5 provider. If i will update all modules it will break compatibility with v3 provider and old terraform versions < 1.0.0. imho it must be other PR with all module updates.

@Gowiem
Copy link
Member

Gowiem commented Sep 20, 2023

@dmitrijn we do want to move towards 1.0.0 -- I would say we pull the band aid off now. If you don't want to sign up for that as part of this PR, then that is understandable, but it will block this PR.

I will surface this conversation in our maintainer slack channel. Thanks for bringing it up!

@hans-d hans-d added stale This PR has gone stale terratest-failing labels Mar 2, 2024
@mergify mergify bot added triage Needs triage and removed stale This PR has gone stale labels Apr 1, 2024
@goruha
Copy link
Member

goruha commented Apr 10, 2024

/terratest

@goruha
Copy link
Member

goruha commented Apr 10, 2024

Resolved conflicts

@goruha
Copy link
Member

goruha commented Apr 10, 2024

/terratest

@mergify mergify bot removed the triage Needs triage label Apr 10, 2024
@goruha goruha merged commit 7ab2c87 into cloudposse:main Apr 10, 2024
25 checks passed
@goruha
Copy link
Member

goruha commented Apr 10, 2024

@dmitrijn Merged.
Thanks for your contribution

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@goruha goruha goruha approved these changes

@osterman osterman osterman approved these changes

@Gowiem Gowiem Awaiting requested review from Gowiem Gowiem is a code owner automatically assigned from cloudposse/contributors

@korenyoni korenyoni Awaiting requested review from korenyoni korenyoni is a code owner automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@dmitrijn @Gowiem @goruha @osterman @hans-d