Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Update pet name when changing launch template id #105

Closed
wants to merge 27 commits into from
Closed

Update pet name when changing launch template id #105

wants to merge 27 commits into from

Conversation

woz5999
Copy link
Contributor

@woz5999 woz5999 commented Jan 19, 2022

what

  • Update pet name when changing launch template id

why

  • If you change the template id, tf/aws will try to create a new node group; however, because we're using create before destroy, it errors out due to "NodeGroup already exists with name food and cluster name bar"
  • generating a new pet name will restore the correct behavior
  • note that this was the behavior prior to Overhaul #84

woz5999 and others added 27 commits September 3, 2020 11:03
@woz5999
fixes
178522a
@woz5999
add cluster security group
d9891a4
@woz5999
fixes
e7d95d4
@woz5999 @Nuru
Update main.tf
95987bd 
Co-authored-by: Nuru <Nuru@users.noreply.github.com>
@woz5999
Merge remote-tracking branch 'upstream/master'
67a1c56
@woz5999
remove remote access sg
9a15c80
@woz5999
updates
8790ea8
@woz5999
simplify
8a8f5ea
@woz5999
don't specify remote_access for launch templates
d230b68
@woz5999
Merge branch 'fixed'
3be9203
@woz5999
cleanup
a52fb7e
@woz5999
Update variables.tf
e0fa427
@woz5999
pass ssh key to launch_template
4ea1a45
@woz5999
var name update
9bdd14f
@woz5999
don't support custom sgs
d8bce3f
@woz5999
recreate default eks node group remote access behavior
ef60992 
https://docs.aws.amazon.com/eks/latest/userguide/sec-group-reqs.html

https://docs.aws.amazon.com/eks/latest/userguide/launch-templates.html
@woz5999
sg name update
d30e60c
@woz5999
missed a remote_access block
9b8f0b6
@Nuru
Restore SSH access, fix some destroy issues with CBD
ee2aa7f
@woz5999
Merge branch 'master' of github.com:woz5999/terraform-aws-eks-node-group
5cc3c61
@woz5999
Merge remote-tracking branch 'upstream/master'
c80385f
@woz5999
update context and tf .14 support
0bf6d7d
@woz5999
cleanup
3a19c32
@woz5999
contxt update and tf .14 support
c6a56d9
@Nuru
Terraform 0.14 upgrade
df5ebfc
@woz5999
Merge branch 'master' of https://github.com/cloudposse/terraform-aws-…
f635092 
…eks-node-group into cloudposse-master
@woz5999
update pet name on new launch template id
bc670d0
@woz5999 woz5999 requested review from a team as code owners January 19, 2022 22:19
@woz5999 woz5999 requested a review from a team as a code owner January 19, 2022 22:19
@woz5999
Copy link
Contributor Author

woz5999 commented Jan 19, 2022

/test all

aknysh
aknysh reviewed Jan 19, 2022
View reviewed changes
context.tf
@@ -20,6 +20,7 @@
# will be null, and `module.this.delimiter` will be `-` (hyphen).
#


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this file has been changed?
It should be taken from https://github.com/cloudposse/terraform-null-label/blob/master/exports/context.tf

aknysh
aknysh reviewed Jan 19, 2022
View reviewed changes
examples/complete/context.tf
@@ -20,6 +20,7 @@
# will be null, and `module.this.delimiter` will be `-` (hyphen).
#


Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

why this file has been changed?
It should be taken from https://github.com/cloudposse/terraform-null-label/blob/master/exports/context.tf

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

ah sorry. i see a pushed of pollution from when i updated my fork. i'll fix everything up nice. i'll set and unset draft status accordingly.

@woz5999 woz5999 marked this pull request as draft January 19, 2022 23:26
@woz5999 woz5999 closed this Jan 19, 2022
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@aknysh aknysh aknysh left review comments

@jhosteny jhosteny Awaiting requested review from jhosteny jhosteny was automatically assigned from cloudposse/contributors

@nitrocode nitrocode Awaiting requested review from nitrocode nitrocode was automatically assigned from cloudposse/contributors

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@woz5999 @aknysh @Nuru