Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Implement Memcached Module #1

Merged
merged 6 commits into from
Aug 9, 2017
Merged

Implement Memcached Module #1

merged 6 commits into from
Aug 9, 2017

Conversation

goruha
Copy link
Member

@goruha goruha commented Jun 22, 2017 •
edited by osterman
Loading

What

  • Implement memcached module

Why

  • Easily provision memcached clusters in a consistent manner

@goruha goruha requested a review from osterman June 22, 2017 10:50
osterman
osterman reviewed Jun 22, 2017
View reviewed changes
main.tf Outdated
}

module "dns" {
source = "../hostname"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use git module repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This still needs to be updated @goruha

osterman
osterman reviewed Jun 22, 2017
View reviewed changes
main.tf Outdated
}

module "dns_config" {
source = "../hostname"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to use git module repo

Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

@goruha bump

osterman
osterman requested changes Jun 26, 2017
View reviewed changes
Copy link
Member

@osterman osterman left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Use git modules

osterman
osterman reviewed Aug 8, 2017
View reviewed changes
main.tf Outdated
@@ -0,0 +1,150 @@
# Define composite variables for resources
module "label" {
source = "git::https://github.com/cloudposse/tf_label.git?ref=init"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Pin to 0.1.0

@osterman osterman changed the title Init Implement Memcached Module Aug 8, 2017
@goruha goruha merged commit 13d7c4d into master Aug 9, 2017
@goruha goruha deleted the init branch August 9, 2017 18:15
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@osterman osterman osterman approved these changes

Assignees

@osterman osterman

Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@goruha @osterman