Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Pass apply_immediately variable to aws_elasticache_cluster resource #13

Merged
merged 1 commit into from
Oct 14, 2020
Merged

Pass apply_immediately variable to aws_elasticache_cluster resource #13

merged 1 commit into from
Oct 14, 2020

Conversation

cdaloisio
Copy link
Contributor

Fixes #12

@osterman
Copy link
Member

/test all

@cdaloisio cdaloisio requested a review from a team as a code owner July 27, 2020 15:21
@cdaloisio
Copy link
Contributor Author

/test all

@jamengual
Copy link

/rebuild-readme

jamengual
jamengual previously approved these changes Oct 6, 2020
View reviewed changes
@jamengual
Copy link

@cdaloisio could you rebase?

@cdaloisio cdaloisio force-pushed the fix-apply-immediately branch 4 times, most recently from f1ee3c7 to de5dd4d Compare October 11, 2020 11:19
@cdaloisio
Copy link
Contributor Author

Sure thing @jamengual 👍
Re-running tests now also!

@cdaloisio
Copy link
Contributor Author

/test all

@cdaloisio
Copy link
Contributor Author

Hmm, I didn't see the emoji from the cloudpossebot acknowledge the test command. Checking the Github actions I saw this error.

Command 'test' is not configured for the user's permission level 'none'.

Perhaps this is a recent change to not prevent non-authorized users from triggering particular commands? In any case, after the tests have run successfully, this should be OK to merge.

@jamengual
Copy link

/test all

@jamengual jamengual merged commit db8bec5 into cloudposse:master Oct 14, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@jamengual jamengual jamengual approved these changes

@nitrocode nitrocode Awaiting requested review from nitrocode

@Gowiem Gowiem Awaiting requested review from Gowiem

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

"apply_immediately" variable has no effect
3 participants
@cdaloisio @osterman @jamengual