Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

Adds support for label order #15

Merged
merged 2 commits into from
Aug 12, 2020
Merged

Adds support for label order #15

merged 2 commits into from
Aug 12, 2020

Conversation

exocom
Copy link
Contributor

@exocom exocom commented Jul 30, 2020

what

  • Adding support for label_order so the "name" & "id" can be customized as intended by the label module.

why

  • The name of the resource was x-dev-1-dev-1 because of how we do tagging.

@exocom exocom requested a review from a team as a code owner July 30, 2020 20:45
@exocom exocom requested review from adamcrews and aknysh and removed request for a team July 30, 2020 20:45
@exocom
Copy link
Contributor Author

exocom commented Aug 1, 2020

/test all

@exocom
Copy link
Contributor Author

exocom commented Aug 1, 2020

/rebuild-readme

@exocom
Copy link
Contributor Author

exocom commented Aug 1, 2020

/test all

@exocom
Copy link
Contributor Author

exocom commented Aug 5, 2020

Can anyone help look at the build? It looks like some infrastructure got left over and needs to be manually removed.

@exocom
Copy link
Contributor Author

exocom commented Aug 12, 2020

/test all

@Gowiem Gowiem changed the title add support for label order Adds support for label order Aug 12, 2020
@Gowiem Gowiem merged commit c9d0aa7 into cloudposse:master Aug 12, 2020
@Gowiem
Copy link
Member

Gowiem commented Aug 12, 2020

@exocom Thanks for the contribution! Released as 0.5.0.

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@Gowiem Gowiem Gowiem approved these changes

@adamcrews adamcrews Awaiting requested review from adamcrews

@aknysh aknysh Awaiting requested review from aknysh

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@exocom @Gowiem @actions-bot