Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Aws provider 3.x #19

Merged
merged 4 commits into from
Sep 15, 2020
Merged

Aws provider 3.x #19

merged 4 commits into from
Sep 15, 2020

Conversation

gusse
Copy link
Contributor

@gusse gusse commented Sep 15, 2020

what

  • enable 3.x AWS provider versions to be used with this module

why

  • latest version should be used, 2.x not getting updates any more
  • other modules you guys are providing are mostly (?) using 3.x already

@gusse gusse requested a review from a team as a code owner September 15, 2020 10:21
@gusse gusse requested review from jhosteny and aknysh and removed request for a team September 15, 2020 10:21
versions.tf Outdated
@@ -2,7 +2,7 @@ terraform {
required_version = ">= 0.12.0, < 0.14.0"
Copy link
Member

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Suggested change
required_version = ">= 0.12.0, < 0.14.0"
required_version = ">= 0.12.0"

please also remove the upper limit for TF version, we don't use upper limit anymore

Copy link
Contributor Author

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Sure, done in bd4d0fe

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gusse
Please see comments

@aknysh
Copy link
Member

aknysh commented Sep 15, 2020

/rebuild-readme

@aknysh
Copy link
Member

aknysh commented Sep 15, 2020

/test all

Copy link
Member

@aknysh aknysh left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

thanks @gusse

@aknysh aknysh merged commit 2b6e7b7 into cloudposse:master Sep 15, 2020
@gusse gusse deleted the aws-provider-3.x branch September 16, 2020 10:32
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
None yet
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants