allow setting single-az with multiple nodes #32

cabrinha · 2021-04-23T17:49:56Z

what

I want to deploy multiple nodes into a single AZ.

why

I run a high throughput, low-latency service in a single AZ. I'd like more elasticache nodes in that AZ.

Signed-off-by: Scott Cabrinha <scott@internaught.io>

Gowiem · 2021-04-24T16:37:34Z

/test all

Gowiem

One request and one question.

variables.tf

Gowiem · 2021-04-24T17:13:17Z

@cabrinha getting the following error from our examples/complete tests:

TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: Error: error creating ElastiCache Cache Cluster: InvalidParameterCombination: Must specify the same number of preferred availability zones as requested number of nodes.
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 	status code: 400, request id: 43fe1952-b785-4737-a754-d6c3fdc3b502
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:   on ../../main.tf line 86, in resource "aws_elasticache_cluster" "default":
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:   86: resource "aws_elasticache_cluster" "default" {
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:

Please look into that and address.

cabrinha · 2021-04-26T16:19:49Z

@cabrinha getting the following error from our examples/complete tests:

TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: Error: error creating ElastiCache Cache Cluster: InvalidParameterCombination: Must specify the same number of preferred availability zones as requested number of nodes.
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 	status code: 400, request id: 43fe1952-b785-4737-a754-d6c3fdc3b502
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:   on ../../main.tf line 86, in resource "aws_elasticache_cluster" "default":
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:   86: resource "aws_elasticache_cluster" "default" {
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121: 
TestExamplesComplete 2021-04-24T16:40:17Z command.go:121:

Please look into that and address.

@Gowiem Thanks for the review. I've updated the PR, let's see if the builds go green.

Gowiem · 2021-04-26T23:16:08Z

/test all

Gowiem · 2021-04-26T23:20:23Z

@cabrinha new issue 😅

TestExamplesComplete 2021-04-26T23:18:20Z command.go:121: 
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121: Error: az_mode "cross-az" is not supported with num_cache_nodes = 1
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121: 
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121:   on ../../main.tf line 86, in resource "aws_elasticache_cluster" "default":
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121:   86: resource "aws_elasticache_cluster" "default" {
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121: 
TestExamplesComplete 2021-04-26T23:18:20Z command.go:121: 
TestExamplesComplete 2021-04-26T23:18:20Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}
TestExamplesComplete 2021-04-26T23:18:20Z retry.go:72: terraform [destroy -auto-approve -input=false -lock=false -var-file fixtures.us-east-2.tfvars]

nitrocode · 2021-04-27T13:53:28Z

Shouldn't the example's az_mode be set to single-az since that's the original default?

https://registry.terraform.io/providers/hashicorp/aws/latest/docs/resources/elasticache_cluster#az_mode

cabrinha · 2021-04-27T18:19:01Z

/test all

nitrocode · 2021-04-27T20:02:53Z

/test all

Gowiem · 2021-04-27T22:55:33Z

/test all

Gowiem · 2021-04-27T23:43:13Z

@cabrinha 💥

TestExamplesComplete 2021-04-27T22:57:57Z command.go:53: Running command terraform with args [apply -input=false -lock=false -auto-approve -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: Error: Reference to undeclared input variable
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121:   on main.tf line 16, in module "subnets":
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121:   16:   availability_zones   = var.availability_zones
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: An input variable with the name "availability_zones" has not been declared.
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: Did you mean "availability_zone"?
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}
TestExamplesComplete 2021-04-27T22:58:00Z retry.go:72: terraform [destroy -auto-approve -input=false -lock=false -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:00Z command.go:53: Running command terraform with args [destroy -auto-approve -input=false -lock=false -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: Error: Reference to undeclared input variable
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121:   on main.tf line 16, in module "subnets":
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121:   16:   availability_zones   = var.availability_zones
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: An input variable with the name "availability_zones" has not been declared.
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: Did you mean "availability_zone"?
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}

Mind looking at that?

cabrinha · 2021-04-27T23:45:22Z

@cabrinha 💥

TestExamplesComplete 2021-04-27T22:57:57Z command.go:53: Running command terraform with args [apply -input=false -lock=false -auto-approve -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: Error: Reference to undeclared input variable
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121:   on main.tf line 16, in module "subnets":
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121:   16:   availability_zones   = var.availability_zones
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: An input variable with the name "availability_zones" has not been declared.
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: Did you mean "availability_zone"?
TestExamplesComplete 2021-04-27T22:58:00Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:00Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}
TestExamplesComplete 2021-04-27T22:58:00Z retry.go:72: terraform [destroy -auto-approve -input=false -lock=false -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:00Z command.go:53: Running command terraform with args [destroy -auto-approve -input=false -lock=false -var-file fixtures.us-east-2.tfvars]
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: Error: Reference to undeclared input variable
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121:   on main.tf line 16, in module "subnets":
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121:   16:   availability_zones   = var.availability_zones
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: An input variable with the name "availability_zones" has not been declared.
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: Did you mean "availability_zone"?
TestExamplesComplete 2021-04-27T22:58:03Z command.go:121: 
TestExamplesComplete 2021-04-27T22:58:03Z retry.go:80: Returning due to fatal error: FatalError{Underlying: exit status 1}

Mind looking at that?

Yeah, just pushed another commit. Looks like I renamed the var when I should have just added a new one.

Gowiem · 2021-04-27T23:45:57Z

/test all

cabrinha · 2021-04-28T02:40:07Z

/test all

Terratest was expecting two subnets to be returned, but I changed the example to be single-az, so I updated the test to expect a single AZ.

Gowiem · 2021-04-28T03:28:00Z

/test all

cabrinha · 2021-04-28T19:00:17Z

Looks like we're good here. Anything else I need to do before merge? @Gowiem

Gowiem · 2021-04-29T22:00:38Z

Thanks for the contribution @cabrinha! Released as 0.12.0.

cabrinha requested review from a team as code owners April 23, 2021 17:49

cabrinha requested review from jamengual and srhopkins and removed request for a team April 23, 2021 17:50

allow setting single-az with multiple nodes

7dfff42

Signed-off-by: Scott Cabrinha <scott@internaught.io>

cabrinha force-pushed the az-mode branch from e50db4b to 7dfff42 Compare April 23, 2021 18:01

Gowiem reviewed Apr 24, 2021

View reviewed changes

variables.tf Outdated Show resolved Hide resolved

fixup example, update var descriptions

f8fc9af

cabrinha force-pushed the az-mode branch from eb02815 to f8fc9af Compare April 26, 2021 16:18

single-az

d7f8c7c

cabrinha force-pushed the az-mode branch from 4a96f06 to d7f8c7c Compare April 27, 2021 18:18

single-az, one zone

868b6be

cabrinha force-pushed the az-mode branch from cf8c140 to 868b6be Compare April 27, 2021 22:18

add zones back in

e133b10

cabrinha force-pushed the az-mode branch from c49e260 to e133b10 Compare April 27, 2021 23:43

cleanup terratest to expect 1 subnet

89a04f4

cabrinha force-pushed the az-mode branch from e851899 to 89a04f4 Compare April 28, 2021 02:31

Auto Format

e708833

Gowiem approved these changes Apr 29, 2021

View reviewed changes

Gowiem merged commit 1c30cd3 into cloudposse:master Apr 29, 2021

cabrinha deleted the az-mode branch April 30, 2021 16:49

Provide feedback

Saved searches

Use saved searches to filter your results more quickly

allow setting single-az with multiple nodes #32

allow setting single-az with multiple nodes #32

cabrinha commented Apr 23, 2021 •

edited

Loading

Gowiem commented Apr 24, 2021

Gowiem left a comment

Gowiem commented Apr 24, 2021

cabrinha commented Apr 26, 2021

Gowiem commented Apr 26, 2021

Gowiem commented Apr 26, 2021

nitrocode commented Apr 27, 2021

cabrinha commented Apr 27, 2021

nitrocode commented Apr 27, 2021

Gowiem commented Apr 27, 2021

Gowiem commented Apr 27, 2021

cabrinha commented Apr 27, 2021

Gowiem commented Apr 27, 2021

cabrinha commented Apr 28, 2021

Gowiem commented Apr 28, 2021

cabrinha commented Apr 28, 2021 •

edited

Loading

Gowiem commented Apr 29, 2021

allow setting single-az with multiple nodes #32

allow setting single-az with multiple nodes #32

Conversation

cabrinha commented Apr 23, 2021 • edited Loading

what

why

Gowiem commented Apr 24, 2021

Gowiem left a comment

Choose a reason for hiding this comment

Gowiem commented Apr 24, 2021

cabrinha commented Apr 26, 2021

Gowiem commented Apr 26, 2021

Gowiem commented Apr 26, 2021

nitrocode commented Apr 27, 2021

cabrinha commented Apr 27, 2021

nitrocode commented Apr 27, 2021

Gowiem commented Apr 27, 2021

Gowiem commented Apr 27, 2021

cabrinha commented Apr 27, 2021

Gowiem commented Apr 27, 2021

cabrinha commented Apr 28, 2021

Gowiem commented Apr 28, 2021

cabrinha commented Apr 28, 2021 • edited Loading

Gowiem commented Apr 29, 2021

cabrinha commented Apr 23, 2021 •

edited

Loading

cabrinha commented Apr 28, 2021 •

edited

Loading