-
-
Notifications
You must be signed in to change notification settings - Fork 37
New issue
Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.
By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.
Already on GitHub? Sign in to your account
allow setting single-az with multiple nodes #32
Conversation
Signed-off-by: Scott Cabrinha <scott@internaught.io>
/test all |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
One request and one question.
@cabrinha getting the following error from our examples/complete tests:
Please look into that and address. |
@Gowiem Thanks for the review. I've updated the PR, let's see if the builds go green. |
/test all |
@cabrinha new issue 😅
|
Shouldn't the example's |
/test all |
1 similar comment
/test all |
/test all |
Mind looking at that? |
Yeah, just pushed another commit. Looks like I renamed the var when I should have just added a new one. |
/test all |
Terratest was expecting two subnets to be returned, but I changed the example to be single-az, so I updated the test to expect a single AZ. |
/test all |
Looks like we're good here. Anything else I need to do before merge? @Gowiem |
what
why